Re: [PATCH 7/7] blk-mq-sched: allow setting of default IO scheduler

From: Jens Axboe
Date: Tue Dec 13 2016 - 10:07:10 EST


On 12/13/2016 03:13 AM, Bart Van Assche wrote:
> On 12/08/2016 09:13 PM, Jens Axboe wrote:
>> +config DEFAULT_MQ_IOSCHED
>> + string
>> + default "mq-deadline" if DEFAULT_MQ_DEADLINE
>> + default "none" if DEFAULT_MQ_NONE
>> +
>> endmenu
>>
>> +config MQ_IOSCHED_ONLY_SQ
>> + bool "Enable blk-mq IO scheduler only for single queue devices"
>> + default y
>> + help
>> + Say Y here, if you only want to enable IO scheduling on block
>> + devices that have a single queue registered.
>> +
>> endif
>
> Hello Jens,
>
> Shouln't the MQ_IOSCHED_ONLY_SQ entry be placed before "endmenu" such
> that it is displayed in the I/O scheduler menu instead of the block menu?

Good catch, yes it should. I'll move it.

--
Jens Axboe