Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

From: Andy Lutomirski
Date: Tue Dec 13 2016 - 11:44:15 EST

On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Andy Lutomirski <luto@xxxxxxxxxx> writes:
>> Eric Biggers pointed out that the orinoco driver pointed scatterlists
>> at the stack.
>> Fix it by switching from ahash to shash. The result should be
>> simpler, faster, and more correct.
>> Cc: stable@xxxxxxxxxxxxxxx # 4.9 only
>> Reported-by: Eric Biggers <ebiggers3@xxxxxxxxx>
>> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> "more correct"? Does this fix a real user visible bug or what? And why
> just stable 4.9, does this maybe have something to do with

Whoops, I had that text in some other patches but forgot to put it in
this one. It'll blow up with CONFIG_VMAP_STACK=y if a debug option
like CONFIG_DEBUG_VIRTUAL=y is set. It may work by accident if
debugging is off.