Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism

From: Milo Kim
Date: Tue Dec 13 2016 - 20:50:36 EST

Hi Jacek,

On 12/13/2016 06:44 PM, Jacek Anaszewski wrote:

Could you please verify if leds-lp55xx-common.c driver
really needs a custom firmware loading fallback mechanism?

Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a misuse case.
I think the right solution is providing device attributes.

At this moment, four drivers use lp55xx-common code.

- lp5521, lp5523: OK if we do not support FW loading fallback mechanism
- lp5562, lp8501: need to create additional sysfs alternatively.

However, we should be careful because I'm not sure this modification will generate the regression (breaking the user-space) or not.

Best regards,