Re: [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf
From: Arnaldo Carvalho de Melo
Date: Wed Dec 14 2016 - 08:25:20 EST
Em Fri, Dec 09, 2016 at 04:30:54PM +0100, Daniel Borkmann escreveu:
> Hi Arnaldo,
> On 12/09/2016 04:09 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 08, 2016 at 06:46:13PM -0800, Joe Stringer escreveu:
> > > (Was "libbpf: Synchronize implementations")
> > >
> > > Update tools/lib/bpf to provide the remaining bpf wrapper pieces needed by the
> > > samples/bpf/ code, then get rid of all of the duplicate BPF libraries in
> > > samples/bpf/libbpf.[ch].
> > >
> > > ---
> > > v3: Add ack for first patch.
> > > Split out second patch from v2 into separate changes for remaining diff.
> > > Add patches to switch samples/bpf over to using tools/lib/.
> > > v2: https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg135088.html
> > > Don't shift non-bpf code into libbpf.
> > > Drop the patch to synchronize ELF definitions with tc.
> > > v1: https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg135088.html
> > > First post.
> > Thanks, applied after addressing the -I$(objtree) issue raised by Wang,
> [ Sorry for late reply. ]
> First of all, glad to see us getting rid of the duplicate lib eventually! :)
> Please note that this might result in hopefully just a minor merge issue
> with net-next. Looks like patch 4/7 touches test_maps.c and test_verifier.c,
> which moved to a new bpf selftest suite  this net-next cycle. Seems it's
> just log buffer and some renames there, which can be discarded for both
> files sitting in selftests.
Yeah, I've got to this point, and the merge has a little bit more than
that, including BPF_PROG_ATTACH/BPF_PROG_DETACH, etc, working on it...