Re: [PATCH] MIPS: NI 169445 board support

From: Rob Herring
Date: Wed Dec 14 2016 - 11:49:27 EST


On Wed, Dec 14, 2016 at 10:32 AM, Nathan Sullivan
<nathan.sullivan@xxxxxx> wrote:
> On Fri, Dec 09, 2016 at 03:18:28PM -0600, Rob Herring wrote:
>> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote:
>> > Support the National Instruments 169445 board.
>> >
>> > Signed-off-by: Nathan Sullivan <nathan.sullivan@xxxxxx>
>> > ---
>> > "gpio: mmio: add support for NI 169445 NAND GPIO" and
>> > "devicetree: add vendor prefix for National Instruments" are required for the
>> > NAND on this board to work.

>> > + ahb@0 {
>> > + compatible = "simple-bus";
>> > + #address-cells = <1>;
>> > + #size-cells = <1>;
>> > + ranges;
>>
>> If everything is under 0x1f3xxxxx, then add in the ranges here (and the
>> unit address).
>>
>
> I noticed that some systems call out their axi/ahb busses, some do not. Would
> you prefer that I remove the bus entirely?

Definitely not. IMO, not having a bus node is an error.

Rob