Re: [PATCH] perf tools: ignore zombie process for user profile
Date: Wed Dec 14 2016 - 14:13:39 EST
Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu:
> > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@xxxxxxxxx wrote:
> > > From: Kan Liang <kan.liang@xxxxxxxxx>
> > > Zombie process is dead process. It is meaningless to profile it.
> > > It's better to ignore it for user profile.
> > I recently posted different patch for same issue:
> > http://marc.info/?l=linux-kernel&m=148153895827359&w=2
> The change as below make me confuse.
> + /* The system wide setup does not work with threads. */
> + if (!evsel->system_wide)
> + return false;
> It looks the meaning of the comments is inconsistent with the code.
> Your original patch doesn't work well with the issue.
> But if I change the above code as below, the issue is fixed.
> if (evsel->system_wide)
> return false;
yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already
in my perf/core branch.