Re: [PATCHv13 2/3] usb: USB Type-C connector class

From: Oliver Neukum
Date: Thu Dec 15 2016 - 07:12:30 EST

On Thu, 2016-12-15 at 13:50 +0200, Heikki Krogerus wrote:

> 1) Should we use "source" and "sink" instead of "device" and "host"
> with the prefer_role attribute after all? I was uncomfortable with
> that when we talked about it last time because the terms kept changing
> with every new Type-C specification version. But I guess "source" and
> "sink" would make sense in the end. This has been requested by several
> guys now.
> 2) Can we change the way we list the supported roles? They are now
> comma separated, but can we use new line instead:
> % cat supported_data_roles
> host
> device
> %
> 3) Instead of the "supports_usb_power_delivery" attribute file which
> we have for the ports and partners, it seem it would be more
> interesting to know the supported USB Power Delivery Specification
> version for some, and also USB Type-C Specification version in
> separate attribute file. So basically we would have
> "usb_power_delivery_version" and "usb_typec_version" attributes
> instead or "supports_usb_power_delivery".
> So would these changes be OK still at this point to everybody?


they are all right with me.