Re: [PATCH] acpi: Fix format string type mistakes

From: Rafael J. Wysocki
Date: Fri Dec 16 2016 - 17:36:51 EST


On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> From: Emese Revfy <re.emese@xxxxxxxxx>
>
> This adds the missing __printf attribute which allows compile time
> format string checking (and will be used by the coming initify gcc
> plugin). Additionally, this fixes the warnings exposed by the attribute.
>
> Signed-off-by: Emese Revfy <re.emese@xxxxxxxxx>
> [kees: split scsi/acpi, merged attr and fix, new commit messages]
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

This modifies code that we get from an external projiect (ACPICA) and
the bugs should be fixed in there in the first place.

Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea.

Thanks,
Rafael