Re: [PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI

From: Darren Hart
Date: Sun Dec 18 2016 - 18:31:32 EST


On Sat, Dec 17, 2016 at 02:54:11PM +0100, Peter Zijlstra wrote:
> On Fri, Dec 16, 2016 at 04:06:39PM -0800, Darren Hart wrote:
> > On Tue, Dec 13, 2016 at 09:36:40AM +0100, Peter Zijlstra wrote:
> > > Thomas spotted that fixup_pi_state_owner() can return errors and we
> > > fail to unlock the rt_mutex in that case.
> > >
> >
> > We handled this explicitly before Patch 1/10, so can this be rolled into 1/10
> > (er 9) as a single commit?
>
> I don't think we did, see how this branch doesn't set pi_mutex.
>

So it is, I stand corrected. So for 2/10 also then:

Reviewed-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>

--
Darren Hart
Intel Open Source Technology Center