Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same

[David Hildenbrand]

Am 16.12.2016 um 18:07 schrieb Radim KrÄmÃÅ:
> 2016-12-16 17:53+0100, Paolo Bonzini:
> > On 16/12/2016 17:41, David Hildenbrand wrote:
> > > Just to verify:
> > >
> > > The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in
> > > kvm_apic_broadcast() ?
> >
> > No, it seems wrong.
>
> Definitely, sending v4 of this patch.
> I'll also add broadcast address check into kvm-unit-tests ...
> ---8<---
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa.  Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
> ---
>  v4: fix xAPIC broadcast address detection [David]
> ---
>  arch/x86/kvm/lapic.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)

Looks good to me.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--

David