Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics

From: Samuel Thibault
Date: Mon Dec 19 2016 - 18:30:55 EST


Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote:
> >> > - if (shares < MIN_SHARES)
> >> > - shares = MIN_SHARES;
> > ...
> >> > return shares;
> >
> > This will only make sure that the returned shares is 2, not 2048.
>
> This is intentional. The MIN_SHARES you are seeing here is overloaded.
> Every "1" unit of share is "SCHED_LOAD_RESOLUTION" bits internally.

I'm not talking about the SCHED_LOAD_RESOLUTION scaling, but about the
SCHED_FIXEDPOINT_SHIFT scaling, which is what
2159197d6677 ("sched/core: Enable increased load resolution on 64-bit kernels")
modified on 64bit platforms.

Samuel