Re: [PATCH] pci: add kernel config option for disabling common PCI quirks

From: John Crispin
Date: Wed Dec 21 2016 - 08:11:34 EST




On 21/12/2016 13:22, Christoph Hellwig wrote:
> On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote:
>> This patch has been lingering inside the OpenWrt for some years. I am not
>> sure if this is the best way to remove the quirks from the build. Let me
>> know if you prefer a different way of solving this.
>
> As a start negative options (_DISABLE_) are very confusing, I would
> recommend to turn this into a postive option with a default y.
>
> On what grounds did you decide which quirks to keep and which to
> remove?
>

Hi Christoph,

I can turn it into an enable patch that is selected by default.

The current patch disables all those quirks that are used for x86/PC
style machines and hence are not required in the embedded world.

John