Re: [PATCH] sgi-xp: use designated initializers

[Robin Holt]

On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.

I guess I don't understand the context enough here to give you a
Signed-off-by.  Can you give us more background on this randomization?

>From what I see in the code here, I can see you are providing
equivalent functionality and I would give it a signed-off-by, but I am
not sure this randomization of which you speak is not going to cause
problems for XP, XPC, XPNET, and XPMEM (out of tree GPL kernel
module).

Robin