Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants

From: Julia Lawall
Date: Fri Dec 23 2016 - 08:04:04 EST


> Hi Julia,
>
> I noticed that drivers/hwmon/gl518sm.c was not converted. Running your script
> on it does not do anything. Any idea what might cause that ?

I believe that it is due to the following:

#define show(type, suffix, value) \
static ssize_t show_##suffix(struct device *dev, \
struct device_attribute *attr, char *buf) \
{ \
struct gl518_data *data = gl518_update_device(dev); \
return sprintf(buf, "%d\n", type##_FROM_REG(data->value)); \
}


Coccinelle doesn't understand the relationship between this macro and the
show functions.

julia