Re: [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set

From: Greg KH
Date: Fri Dec 23 2016 - 13:09:13 EST


On Fri, Dec 23, 2016 at 08:33:55PM +0800, Jisheng Zhang wrote:
> dw8250_acpi_match is used only when ACPI is enabled. Fix the following
> gcc warning when W=1 is set:
>
> drivers/tty/serial/8250/8250_dw.c:640:36: warning: 'dw8250_acpi_match'
> defined but not used [-Wunused-const-variable=]

Don't set W=1 then, this type of "fix" is foolish and is just going to
make code messier, sorry.

greg k-h