Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

From: Sergei Shtylyov
Date: Sun Dec 25 2016 - 05:07:26 EST


On 12/25/2016 3:30 AM, Thomas Preisner wrote:

In some cases the return value of a failing function is not being used
and the function typhoon_init_one() returns another negative error
code instead.

Signed-off-by: Thomas Preisner <thomas.preisner+linux@xxxxxx>
Signed-off-by: Milan Stephan <milan.stephan+linux@xxxxxx>
drivers/net/ethernet/3com/typhoon.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

In addition to what DaveM said, your choise of the subject prefixes is too wide -- it would seem that you're fixing all 3com drivers, while you're only fixing typhoon. That "typhoon:" alone would have been an appropriate prefix.

MBR, Sergei