Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash
From: Ard Biesheuvel
Date: Mon Dec 26 2016 - 12:52:21 EST
On 26 December 2016 at 07:57, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Dec 24, 2016 at 09:57:53AM -0800, Andy Lutomirski wrote:
>> I actually do use incremental hashing later on. BPF currently
>> vmallocs() a big temporary buffer just so it can fill it and hash it.
>> I change it to hash as it goes.
> How much data is this supposed to hash on average? If it's a large
> amount then perhaps using the existing crypto API would be a better
> option than adding this.
This is a good point actually: you didn't explain *why* BPF shouldn't
depend on the crypto API.