Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value
From: David Dillow
Date: Tue Dec 27 2016 - 16:15:36 EST
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
> Those spaces were actually left out purposely: The file in question (typhoon.c)
> is missing those spaces between the statements (if, for, while) and the
> following opening bracket pretty much always (except 2-3 times) and we figured
> that it might be better to keep the coding style consistent since this might
> aswell have been intended by the original author.
I'm not sure if we had the rule back then, or if I just missed it.
Either way, we should follow the rules for new code if we can.
I'm not sure it's worth fixing all of the instances -- usually
formatting-only changes are not worth the churn -- but I don't have a
strong opinion on the matter.