Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

From: Andy Shevchenko
Date: Tue Dec 27 2016 - 17:15:42 EST

On Tue, Dec 27, 2016 at 3:51 PM, Pali RohÃr <pali.rohar@xxxxxxxxx> wrote:
> On Tuesday 27 December 2016 14:43:49 Wolfram Sang wrote:
>> > Dell platform team told us that some (DMI whitelisted) Dell
>> > Latitude machines have ST microelectronics accelerometer at i2c
>> > address 0x29. That
>> > i2c address is not specified in DMI or ACPI, so runtime detection
>> > without
>> > whitelist which is below is not possible.
>> I'd think this should rather live somewhere in
>> drivers/platform/x86/dell*.c?
> i2c_new_device() with lis3lv02d for i801 i2c bus needs to be called
> after initializing i2c-i801 bus driver.
> I have no idea how to do it (properly) outside of i2c-i801.c file.

I doubt we need a single line of code for this. See [1] and perhaps
create an EFI variable with necessary upgrade device node.

> Same thing is done for Fujitsu machines, see function
> i801_probe_optional_slaves() in i2c-i801.c file. So I did similar
> approach for Dell machines.

Perhaps, this also needs to be converted to use EFI variable.


With Best Regards,
Andy Shevchenko