Re: [PATCH 00/15] hyperv: more stuff to uapi + cleanup
From: Roman Kagan
Date: Wed Dec 28 2016 - 15:33:25 EST
[ Sorry for such a slow reply; flu and office relocation knocked me out
for a while ]
On Wed, Dec 21, 2016 at 06:00:17PM +0000, KY Srinivasan wrote:
> > -----Original Message-----
> > From: Roman Kagan [mailto:rkagan@xxxxxxxxxxxxx]
> > Sent: Tuesday, December 20, 2016 7:56 AM
> > Subject: [PATCH 00/15] hyperv: more stuff to uapi + cleanup
> > Expose more Hyper-V-related definitions in the uapi header for
> > consumption by userspace.
> > While doing so, get rid of a number of duplications between the KVM and
> > the guest driver code. Also a few other cleanups are made which are not
> > strictly necessary for the main purpose of the series but appear
> > reasonable to do at the same time.
> > The most controversial is the last patch which modifies the stuff
> > already published in the uapi header, in the hope that no userspace
> > applications have started relying on it; I'm ok dropping it if this is
> > unacceptable.
> First, let me thank you. Broadly, this patch-set can be broken into
> 1. Moving existing definitions around - (to make it possible to share these
> between Hyper-V guest drivers and KVM)
> 2. Cleanup of the existing code in the VMBUS driver (under drivers/hv).
Right. Another significant part of the series is, where two sets of
definitions exist for the same entity, consolidate on the one that looks
more Linux-style, usually the one in the (currently) uapi header.
> To the extent possible, I want to take all non-KVM code through Greg's tree.
> We can then modify the KVM code to use these common definitions.
Well, this patchset touches almost no KVM code, so we're fine here I
> Currently, I too am working on restructuring VMBUS driver code to
> fully isolate all x86 dependencies. I can work with you on
> integration as I too am moving things around.
Great! Do you want me to rebase on some your public tree? (Once I
split the patches as you requested, of course)?