Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
From: Robert Jarzmik
Date: Thu Dec 29 2016 - 02:21:24 EST
Linus Walleij <linus.walleij@xxxxxxxxxx> writes:
> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote:
>> In functions pxa2xx_build_functions, the memory allocated for
>> 'functions' is live within the function only. After the
>> allocation it is immediately freed with devm_kfree. There is
>> no need to allocate memory for 'functions' with devm function
>> so replace devm_kcalloc with kcalloc and devm_kfree with kfree.
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> I want the maintainer Robert Jarzmik to review this before I do anything
I did review, on December the 10th. I wasn't very enthusiastic about the patch,
if you check back my reply.