Re: [PATCH 5/7] mm, vmscan: extract shrink_page_list reclaim counters into a struct

From: Hillf Danton
Date: Thu Dec 29 2016 - 03:06:19 EST




On Wednesday, December 28, 2016 11:31 PM Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> shrink_page_list returns quite some counters back to its caller. Extract
> the existing 5 into struct reclaim_stat because this makes the code
> easier to follow and also allows further counters to be returned.
>
> While we are at it, make all of them unsigned rather than unsigned long
> as we do not really need full 64b for them (we never scan more than
> SWAP_CLUSTER_MAX pages at once). This should reduce some stack space.
>
> This patch shouldn't introduce any functional change.
>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
> ---
Acked-by: Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx>