Re: [alsa-devel] [PATCH] Revert "ASoC: core: replace aux_comp_list to component_dev_list"
From: Sylwester Nawrocki
Date: Thu Dec 29 2016 - 11:18:37 EST
On 12/29/2016 03:49 PM, Nikita Yushchenko wrote:
> This reverts commit 1a653aa44725668590b36bbe2d7fe4736a69f055 ("ASoC:
> core: replace aux_comp_list to component_dev_list").
> That commit tries to remove card->aux_comp_list, using flagged entries
> in card->component_dev_list instead.
> However, components are added to card->component_dev_list in
> soc_probe_component(), which is called for aux devices by
> soc_probe_aux_devices(). Before that commit, it traversed
> card->aux_comp_list and found aux devices added by soc_bind_aux_dev().
> After that commit, it traverses card->component_dev_list and finds no
> aux devices, because soc_probe_component() was not yet called for them.
> Thus all aux devices are lost and any setup that needs them no longer
I think we can't simply revert that commit now, after commit
9178feb ASoC: add Component level suspend/resume
component_dev_list is also used for the component level suspend/resume,
if auxiliary devices would have been on a separate list they would be
missed in the suspend/resume sequences.
I run into same issue and posted a patch:
"ASoC: Fix binding and probing of auxiliary components".