Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute__((...))")

From: Joe Perches
Date: Sat Dec 31 2016 - 11:31:33 EST


On Sat, 2016-12-31 at 17:03 +0800, Herbert Xu wrote:
> On Fri, Dec 30, 2016 at 04:49:28PM -0800, Joe Perches wrote:
> >
> > Perhaps it'd be better to remove the declaration/prototype
> > of crypto_ablkcipher_show and surround the definition of
> > crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif
>
> No that's stupid. We want to maximise the compiler coverage.

stupid is rather a strong word for the most
common technique used in the kernel to avoid
compiler warnings.