Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.

From: Arnd Bergmann
Date: Sat Dec 31 2016 - 15:24:23 EST

On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote:
> On 12/29/2016 11:37 PM, Greentime Hu wrote:
> > Signed-off-by: Greentime Hu <>
> This is not enough, you need to add a Device Tree binding document under
> Documentation/devicetree/bindings/net/ which documents this compatible
> string, as well as additional properties that may be required to
> describe this hardware block.

We already have


for the same hardware (though used by a different driver).

I'd suggest renaming that one to a more generic file name and
adding the new compatible string there.

Aside from that, every patch should also have a changelog comment.