Re: [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers

From: Tony Lindgren
Date: Mon Jan 02 2017 - 17:02:24 EST


* Linus Walleij <linus.walleij@xxxxxxxxxx> [170102 13:44]:
> On Mon, Jan 2, 2017 at 7:20 PM, Gary Bisson
> <gary.bisson@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > This series is a follow-up to Linus suggestion to use the generic helpers
> > introduced by Tony [1].
> >
> > Mainly I've used the generic functions in pinctrl_ops and pinmux_ops and
> > switched to the generic group/function_desc structures instead of the
> > imx-specific one that didn't bring anything special.
>
> Awesome job. Really nice!
>
> > However I couldn't use the 'add' functions to add elements since the
> > parsing is done at probe time in its own way. So I've kept the
> > radix_insert functions. This could be modified in the future though.
>
> Let's see if Tony has some ideas. We already save a bunch of
> code by this which is very nice.

I attempted a generic iterator in the ti-iodelay.c but so far
did not really manage to simplify it at all..

Tony