Re: [PATCH 1/4] perf, tools: Add probing for xed

From: Jiri Olsa
Date: Tue Jan 03 2017 - 09:59:42 EST


On Tue, Jan 03, 2017 at 01:00:26AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Add autoprobing for the xed disassembler library.
>
> Can be downloaded from https://github.com/intelxed/xed
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
> tools/build/Makefile.feature | 6 ++++--
> tools/build/feature/Makefile | 8 ++++++--
> tools/build/feature/test-all.c | 5 +++++
> tools/build/feature/test-xed.c | 9 +++++++++
> tools/perf/Makefile.config | 5 +++++
> 5 files changed, 29 insertions(+), 4 deletions(-)
> create mode 100644 tools/build/feature/test-xed.c
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index e3fb5ecbdcb6..25183fa39963 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -63,7 +63,8 @@ FEATURE_TESTS_BASIC := \
> lzma \
> get_cpuid \
> bpf \
> - sdt
> + sdt \
> + xed
>
> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
> # of all feature tests
> @@ -105,7 +106,8 @@ FEATURE_DISPLAY ?= \
> zlib \
> lzma \
> get_cpuid \
> - bpf
> + bpf \
> + xed

please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed
package yet, just the sources, so the "xed: OFF" build message would
bother almost everyone probably for long time..

thanks,
jirka