Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a new insn-utils

From: Dave Hansen
Date: Tue Jan 03 2017 - 11:44:17 EST


On 12/23/2016 05:37 PM, Ricardo Neri wrote:
> Other kernel submodules can benefit from using the utility functions
> defined in mpx.c to obtain the addresses and values of operands contained
> in the general purpose registers. An instance of this is the emulation code
> used for instructions protected by the Intel User-Mode Instruction
> Prevention feature.

I haven't looked at this in detail, but as long as this is pretty much a
straight code move, I don't see any issues with it from an MPX
perspective. I'm glad to see it getting reused.

Feel free to add my Acked-by on it if you like.