Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

[Noralf TrÃnnes]

Den 03.01.2017 17:12, skrev Andy Shevchenko:
> On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote:
> > Fall back to usual allocation method if DMA coherent allocation fails.
> >
> > SPI framework will map and use DMA mapped memory when possible.
> Locally I have re-done DMA approach and thus this patch became optional.
>
> Should I leave or remove it? Opinions?

If we use kmalloc always, then this goes away.

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/staging/fbtft/fbtft-core.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/fbtft/fbtft-core.c
> > b/drivers/staging/fbtft/fbtft-core.c
> > index 226be8c09768..9f024986aff4 100644
> > --- a/drivers/staging/fbtft/fbtft-core.c
> > +++ b/drivers/staging/fbtft/fbtft-core.c
> > @@ -843,7 +843,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct
> > fbtft_display *display,
> >   		if (dma) {
> >   			txbuf = dmam_alloc_coherent(dev, txbuflen,
> >   						    &par->txbuf.dma,
> > GFP_DMA);
> > -		} else
> > +		}
> > +		if (!txbuf)
> >   #endif
> >   		{
> >   			txbuf = devm_kzalloc(par->info->device,