Re: Fix usage of true and false as field names in struct taint_flag

[Jessica Yu]

+++ Valdis Kletnieks [26/12/16 18:49 -0500]:
> The commit 7fd8329ba502ef76dd ("taint/module: Clean up global and
> module taint flags handling") contains this chunk:
>
> +struct taint_flag {
> +       char true;      /* character printed when tainted */
> +       char false;     /* character printed when not tainted */
> +       bool module;    /* also show as a per-module taint flag */
> +};
>
> and hilarity ensues when an out-of-tree module has this:
>
> # ifndef true
> #  define true  (1)
> # endif
> # ifndef false
> #  define false (0)
> # endif
>
> Change the field names to not shadow something likely to be used
> by third-party modules.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

[ added Rusty and Larry to CC ]

Hm, you and Larry Finger sent the exact same fix at around the same
time, although I think people are leaning towards the other patch
(it's just a naming preference), see here:

  https://lkml.kernel.org/r/20161224195532.15128-1-Larry.Finger@xxxxxxxxxxxx

I plan to take the other patch, but since you first reported the
issue to lkml, and additionally sent a fix in response, I will add a
Reported-by: tag to the patch so I can also give you credit.

Thanks Valdis!

Jessica