Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch

[Andy Shevchenko]

On Thu, Jan 5, 2017 at 3:03 AM, Junichi Nomura <j-nomura@xxxxxxxxxxxxx> wrote:
> We allocate struct ucode_patch here.
>
> "size" is a size of microcode data and used for kmemdup() later
> in this function.
>
> Signed-off-by: Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx>
> Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
>
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index aee3cb5..042f329 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -150,7 +150,7 @@ static struct ucode_patch *__alloc_microcode_buf(void *data, unsigned int size)
>  {
>         struct ucode_patch *p;
>
> -       p = kzalloc(size, GFP_KERNEL);
> +       p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);

Perhaps sizeof(*p) ?

>         if (!p)
>                 return ERR_PTR(-ENOMEM);

-- 
With Best Regards,
Andy Shevchenko