Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node

From: Chanwoo Choi
Date: Fri Jan 06 2017 - 17:11:04 EST


Hi,

2017-01-07 6:31 GMT+09:00 Chanwoo Choi <cwchoi00@xxxxxxxxx>:
> Hi,
>
> 2017-01-06 22:43 GMT+09:00 Andi Shyti <andi.shyti@xxxxxxxxxxx>:
>> From: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
>>
>> Add DT node support for TM2 touchkey device.
>>
>> Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx>
>> Signed-off-by: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
>> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
>> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index 2449266b268f..92fcc4ec8319 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -18,6 +18,19 @@
>> compatible = "samsung,tm2", "samsung,exynos5433";
>> };
>>
>> +&hsi2c_9 {
>> + status = "okay";
>> +
>> + touchkey@20 {
>> + compatible = "samsung,tm2-touchkey";
>> + reg = <0x20>;
>> + interrupt-parent = <&gpa3>;
>> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>> + vcc-supply = <&ldo32_reg>;
>> + vdd-supply = <&ldo33_reg>;
>> + };
>> +};
>> +
>> &ldo31_reg {
>> regulator-name = "TSP_VDD_1.85V_AP";
>> regulator-min-microvolt = <1850000>;
>
> Looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>
> --
> Best Regards,
> Chanwoo Choi



--
Best Regards,
Chanwoo Choi