Re: [PATCH 1/2] arc: rename xCCM sections so they are not merged in global .data/.text

From: Alexey Brodkin
Date: Mon Jan 09 2017 - 10:08:38 EST


Hi Vineet,

On Thu, 2016-12-22 at 16:25 -0800, Vineet Gupta wrote:
> On 12/22/2016 06:09 AM, Alexey Brodkin wrote:
> > diff --git a/arch/arc/include/asm/linkage.h b/arch/arc/include/asm/linkage.h
> > index b29f1a9fd6f7..3a5f13d65ee1 100644
> > --- a/arch/arc/include/asm/linkage.h
> > +++ b/arch/arc/include/asm/linkage.h
> > @@ -28,7 +28,7 @@
> > Â/* annotation for data we want in DCCM - if enabled in .config */
> > Â.macro ARCFP_CODE
> > Â#ifdef CONFIG_ARC_HAS_ICCM
> > - .section .text.arcfp, "ax",@progbits
> > + .section .text..arcfp, "ax",@progbits
>
> Why not turn this around and call it arcfp.text and arcfp.data etc - just like
> done for other special sections such as sched, cpuidle, lock... Just so we are
> consistent with normal kernel convention !

Right that looks much better!
Will do so in v2.

-Alexey