Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

[Vivien Didelot]

Hi Randy,

Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:

> On 01/08/17 17:18, Florian Fainelli wrote:
>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>
>>> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
>> 
>> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> 
>
> but when CONFIG_INET is not enabled, the patch causes this warning:
>
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)

Thanks for spotting that! Would that be enough to change this first?

    diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
    index 675acbf1502d..c7263b70e72b 100644
    --- a/net/dsa/Kconfig
    +++ b/net/dsa/Kconfig
    @@ -1,6 +1,6 @@
    config HAVE_NET_DSA
            def_bool y
    -       depends on NETDEVICES && !S390
    +       depends on INET && NETDEVICES && !S390

    # Drivers must select NET_DSA and the appropriate tagging format

Thanks,

        Vivien