Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()

From: Linus Walleij
Date: Mon Jan 09 2017 - 13:32:39 EST


On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 8 Jan 2017 18:44:26 +0100
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> * Replace the specification of a data structure by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Chunyan has been running this test code so she might have additional
insights to provide. I am not aware about anyone else really running the
tests, are there people who do it?

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij