Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

From: Paul Menzel
Date: Wed Jan 11 2017 - 05:20:16 EST


Dear Tomas,


On 01/11/17 10:24, Winkler, Tomas wrote:

On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote:
On older platforms the command should be just ignored by the firmware
but some older platforms misbehave so it's safer to send the command
only if required.

Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s).

What about Dell XPS13?

With Linus’ master branch from today, and Greg’s char-misc-linus merged (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there.

I am now building a Linux kernel image with the two commits touching `bus-fixup.c` reverted.

Do you want me to open a separate bug report for that, or continue debugging in the existing report [1], which is currently marked as resolved?

Do you have Kaby Lake devices sitting around for testing?


Kind regards,

Paul


[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
"[Bug 192051] [bisected] No hibernation/suspend/shutdown after commit 7279b238badec09efd0545293e64c21feee97f73"