Re: [PATCHv3 3/8] rtc: add STM32 RTC driver

From: Alexandre Belloni
Date: Wed Jan 11 2017 - 05:50:19 EST


On 11/01/2017 at 11:42:50 +0100, Amelie DELAUNAY wrote :
>
> On 01/11/2017 11:17 AM, Alexandre Belloni wrote:
> > On 11/01/2017 at 11:07:16 +0100, Amelie DELAUNAY wrote :
> > > > This will never happen, tm is already checked multiple times (up to
> > > > three) in the core before this function can be called.
> > > >
> > > You're right. I'll remove all rtc_valid_tm calls.
> >
> > You can keep the one in read_time
> >
> Even if rtc_valid_tm is called just after rtc->ops->read_time() in
> __rtc_read_time ?

Ah yes, I forgot it was added, you can remove all of them.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com