Re: [PATCH] afs: correctly use 64-bit time for UUID

From: Arnd Bergmann
Date: Wed Jan 11 2017 - 09:04:27 EST


On Wednesday, January 11, 2017 1:51:32 PM CET David Howells wrote:
> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > From: Tina Ruchandani <ruchandani.tina@xxxxxxxxx>
> >
> > UUID calculation uses 'struct timespec' whose seconds will overflow
> > in year 2038 and beyond for 32-bit systems. This patch removes the
> > dependency on 'struct timespec' by using ktime_get_real().
> > While the patch does not fix a 'bug' as such, it is part of a larger
> > effort to remove instances of 'struct timespec' and other data-structures
> > suffering from y2038 problem from the kernel.
>
> Is it worth abstracting out in-kernel UUID generation?

Do you mean moving it out of AFS into lib/*.c? I think the 'afs_uuid'
structure is quite different from other UUID definitions, so that wouldn't
work.

Arnd