Re: [PATCH 2/2] btrfs: drop gfp mask tweaking in try_release_extent_state

From: David Sterba
Date: Wed Jan 11 2017 - 11:04:10 EST


On Mon, Jan 09, 2017 at 03:39:03PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> try_release_extent_state reduces the gfp mask to GFP_NOFS if it is
> compatible. This is true for GFP_KERNEL as well. There is no real
> reason to do that though. There is no new lock taken down the
> the only consumer of the gfp mask which is
> try_release_extent_state
> clear_extent_bit
> __clear_extent_bit
> alloc_extent_state
>
> So this seems just unnecessary and confusing.
>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>