Re: [PATCH] regulator: core: Don't use regulators as supplies until the parent is bound

From: Jon Hunter
Date: Wed Jan 11 2017 - 11:57:28 EST



On 10/01/17 16:57, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Jan 10, 2017 at 11:01:09AM +0000, Jon Hunter wrote:
>
>> +++ b/drivers/regulator/core.c
>> @@ -1553,6 +1553,11 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
>> }
>> }
>>
>> + if (r->dev.parent && !device_is_bound(r->dev.parent)) {
>> + put_device(&r->dev);
>> + return -EPROBE_DEFER;
>> + }
>> +
>
> I realised earlier that this will trigger when the supply and the
> consumer are part of the same PMIC which will cause issues as that's a
> fairly common setup and won't be resolved by deferring. Can you please
> modify this to only defer if the parent is not the same as the parent of
> the regulator we're currently resolving? Sorry, should've thought of
> this yesterday.

OK, no problem. Will send out an update shortly.

Cheers
Jon

--
nvpublic