Re: [patch] KEYS: Fix an error code in request_master_key()

From: David Howells
Date: Thu Jan 12 2017 - 08:15:23 EST


Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 2016-12-16 at 12:08 +0300, Dan Carpenter wrote:
> > This function has two callers and neither are able to handle a NULL
> > return. Really, -EINVAL is the correct thing return here anyway. This
> > fixes some static checker warnings like:
> >
> > security/keys/encrypted-keys/encrypted.c:709 encrypted_key_decrypt()
> > error: uninitialized symbol 'master_key'.
> >
> > Fixes: 7e70cb497850 ("keys: add new key-type encrypted")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Thanks!

Can I put that down as an Acked-by or Reviewed-by?

David