[PATCH 1/4] platform/x86: fujitsu-laptop: simplify acpi_bus_register_driver() error handling

From: MichaÅ KÄpieÅ
Date: Fri Jan 13 2017 - 06:03:07 EST


A separate variable is not needed to handle error codes returned by
acpi_bus_register_driver(). If the latter fails, just use the value it
returned as the value returned by fujitsu_init().

Signed-off-by: MichaÅ KÄpieÅ <kernel@xxxxxxxxxx>
---
drivers/platform/x86/fujitsu-laptop.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index b725a907a91f..9f62d9e1b0de 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -1176,7 +1176,7 @@ MODULE_DEVICE_TABLE(acpi, fujitsu_ids);

static int __init fujitsu_init(void)
{
- int ret, result, max_brightness;
+ int ret, max_brightness;

if (acpi_disabled)
return -ENODEV;
@@ -1191,11 +1191,9 @@ static int __init fujitsu_init(void)
fujitsu->keycode5 = KEY_RFKILL;
dmi_check_system(fujitsu_dmi_table);

- result = acpi_bus_register_driver(&acpi_fujitsu_driver);
- if (result < 0) {
- ret = -ENODEV;
+ ret = acpi_bus_register_driver(&acpi_fujitsu_driver);
+ if (ret)
goto fail_acpi;
- }

/* Register platform stuff */

@@ -1248,11 +1246,9 @@ static int __init fujitsu_init(void)
goto fail_hotkey;
}

- result = acpi_bus_register_driver(&acpi_fujitsu_hotkey_driver);
- if (result < 0) {
- ret = -ENODEV;
+ ret = acpi_bus_register_driver(&acpi_fujitsu_hotkey_driver);
+ if (ret)
goto fail_hotkey1;
- }

/* Sync backlight power status (needs FUJ02E3 device, hence deferred) */
if (acpi_video_get_backlight_type() == acpi_backlight_vendor) {
--
2.11.0