Re: [PATCH] cxgb4: Remove redundant memset before memcpy

From: Tobias Klauser
Date: Sat Jan 14 2017 - 07:28:49 EST


On 2017-01-14 at 02:17:40 +0100, Shyam Saini <mayhs11saini@xxxxxxxxx> wrote:
> The region set by the call to memset, immediately overwritten by
> the subsequent call to memcpy and thus makes the memset redundant.
>
> Also remove the memset((&info, 0, sizeof(info)) on line 398 because
> info is memcpy()'ed to before being used in the loop and it isn't
> used outside of the loop.
>
> Signed-off-by: Shyam Saini <mayhs11saini@xxxxxxxxx>

Reviewed-by: Tobias Klauser <tklauser@xxxxxxxxxx>