Re: [PATCH 0/2] Style fixes: open code obfuscating macros

From: jmrodriguezhw88
Date: Sun Jan 15 2017 - 17:38:39 EST


On Monday, January 2, 2017 at 5:31:15 PM UTC-8, Logan Gunthorpe wrote:
> Hi,
>
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
> suggested I fix the problem at the source.
>
> Thus, please merge the following two patches to improve the style of
> the NTB drivers.
>
> Thanks,
>
> Logan
>
> [1] http://www.spinics.net/lists/linux-pci/msg56904.html
>
>
> Logan Gunthorpe (2):
> ntb_hw_amd: Style fixes: open code macros that just obfuscate code
> ntb_hw_intel: Style fixes: open code macros that just obfuscate code
>
> drivers/ntb/hw/amd/ntb_hw_amd.c | 59 ++++++++-------
> drivers/ntb/hw/amd/ntb_hw_amd.h | 3 -
> drivers/ntb/hw/intel/ntb_hw_intel.c | 145 ++++++++++++++++++------------------
> drivers/ntb/hw/intel/ntb_hw_intel.h | 3 -
> 4 files changed, 104 insertions(+), 106 deletions(-)
>
> --
> 2.1.4