Re: [patch v2] mm, memcg: do not retry precharge charges

From: Michal Hocko
Date: Mon Jan 16 2017 - 02:35:51 EST


On Sat 14-01-17 21:42:48, David Rientjes wrote:
> On Sat, 14 Jan 2017, Johannes Weiner wrote:
>
> > The OOM killer livelock was the motivation for this patch. With that
> > ruled out, what's the point of this patch? Try a bit less hard to move
> > charges during task migration?
> >
>
> Most important part is to fail ->can_attach() instead of oom killing
> processes when attaching a process to a memcg hierarchy.

But we are not invoking the oom killer from this path even without
__GFP_NORETRY. Or am I missing your point?

--
Michal Hocko
SUSE Labs