Re: [PATCH] ALSA: mips: avoid potential uninitialized variable use

From: Arnd Bergmann
Date: Mon Jan 16 2017 - 08:26:37 EST


On Mon, Jan 16, 2017 at 1:28 PM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> On Mon, 16 Jan 2017 12:04:56 +0100,
> Arnd Bergmann wrote:
>> It's easy enough to avoid by adding a 'default' clause to the switch
>> statements here. I assume that in practice no other case can happen,
>> but adding a default puts us on the safe side and shuts up the warnings.
>
> Well, these cases are logical errors that must not happen, so
> returning an error would be a "safer", IMO.

Agreed. I sent out a v2 now.

Arnd