Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume

From: Andrew F. Davis
Date: Mon Jan 16 2017 - 11:42:11 EST


On 01/14/2017 09:51 PM, Alison Schofield wrote:
> The suspend/resume functions were using dev_to_iio_dev() to get
> the iio_dev. That only works on IIO dev's. Replace it with spi
> functions to get the correct iio_dev.
>
> Signed-off-by: Alison Schofield <amsfield22@xxxxxxxxx>

Was this found with an automated tool? If not, it might be nice to have
a Coccinelle style check for this. Anyway for this and the afe4404
version patch:

Acked-by: Andrew F. Davis <afd@xxxxxx>

> ---
> drivers/iio/health/afe4403.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
> index 9a08146..6bb23a4 100644
> --- a/drivers/iio/health/afe4403.c
> +++ b/drivers/iio/health/afe4403.c
> @@ -422,7 +422,7 @@ MODULE_DEVICE_TABLE(of, afe4403_of_match);
>
> static int __maybe_unused afe4403_suspend(struct device *dev)
> {
> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
> struct afe4403_data *afe = iio_priv(indio_dev);
> int ret;
>
> @@ -443,7 +443,7 @@ static int __maybe_unused afe4403_suspend(struct device *dev)
>
> static int __maybe_unused afe4403_resume(struct device *dev)
> {
> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
> struct afe4403_data *afe = iio_priv(indio_dev);
> int ret;
>
>