Re: arm: module: Add apply_relocate_add

[Jessica Yu]

+++ Abel Vesa [06/12/16 17:06 +0000]:
> It was only added to fix compiler error. It is not implemented
> yet.
>
> Signed-off-by: Abel Vesa <abelvesa@xxxxxxxxx>
> ---
> arch/arm/kernel/module.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
> index 4f14b5c..bf94922 100644
> --- a/arch/arm/kernel/module.c
> +++ b/arch/arm/kernel/module.c
> @@ -52,6 +52,15 @@ void *module_alloc(unsigned long size)
> #endif
>
> int
> +apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab,
> +		   unsigned int symindex, unsigned int relindex,
> +		   struct module *module)
> +{
> +	/* Not implemented yet */
> +	return 0;
> +}

Are SHT_RELA relocation sections actually supported on 32-bit arm? It looks
like there's only support for SHT_REL.

arch/arm/Kconfig:84:	select MODULES_USE_ELF_REL

If we support SHT_REL sections, the correct fix is to probably have
klp_write_object_relocations() check if the relocation section is
SHT_REL or SHT_RELA, and call the appropriate function (apply_relocate
or apply_relocate_add), similar to how the module loader does it.

Jessica