Re: [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver

From: Javier Martinez Canillas
Date: Tue Jan 17 2017 - 09:35:13 EST


Hello Andi,

On 01/17/2017 10:54 AM, Andi Shyti wrote:
> Add binding for the STMicroelectronics FingerTip (stmfts)
> touchscreen driver.
>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> ---

The binding looks good to me, I've just a minor nit below.

[snip]

> +
> +i2c@00000000 {
> +
> + /* ... */
> +
> + stmfts@49 {

The ePAPR document says:

The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model.

So I think this should be touchscreen@49 instead.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America