Re: [PATCH] m68k: Replaced all gcc specific macros with macros from compiler.h

[Geert Uytterhoeven]

Hi Gideon,

On Tue, Jan 17, 2017 at 10:39 AM, Gideon Israel Dsouza
<gidisrael@xxxxxxxxx> wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for all files
> under /arch/m68k
>
> Note: I sent in a patch for a similar cleanup for /crypto this is
> in the commit d8c34b949d8c9
> (crypto: Replaced gcc specific attributes with macros from compiler.h)
> This commit is currently in linux-next and has changes inside
> compiler-gcc.h just like this patch does. Just highlighting this incase
> there are merge issues.

As this series touches two direct subsystems (arch/m68k and include/linux),
I think it would be better to split it in two parts, and get the include/linux
part included first (through Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>?).

> ---
>  arch/m68k/68000/bootlogo-vz.h     |   4 +-
>  arch/m68k/68000/bootlogo.h        |   5 +-
>  arch/m68k/include/asm/MC68328.h   | 110 ++++++++++++++--------------
>  arch/m68k/include/asm/MC68EZ328.h | 148 +++++++++++++++++++-------------------
>  arch/m68k/include/asm/MC68VZ328.h | 148 +++++++++++++++++++-------------------
>  arch/m68k/include/asm/natfeat.h   |   3 +-
>  arch/m68k/lib/ashldi3.c           |   8 +--
>  arch/m68k/lib/ashrdi3.c           |   8 +--
>  arch/m68k/lib/lshrdi3.c           |   8 +--
>  arch/m68k/lib/muldi3.c            |  10 +--
>  include/linux/compiler-gcc.h      |   1 +
>  11 files changed, 232 insertions(+), 221 deletions(-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds